Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding globalThis typeof check #6127

Merged
merged 2 commits into from Mar 8, 2024
Merged

Adding globalThis typeof check #6127

merged 2 commits into from Mar 8, 2024

Conversation

marklundin
Copy link
Member

This PR adds a typeof check on globalThis to gracefully fallback on older browsers

Addresses #6108 (comment)

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin marklundin requested a review from slimbuck March 8, 2024 09:45
@marklundin marklundin self-assigned this Mar 8, 2024
@marklundin marklundin added the bug label Mar 8, 2024
@marklundin marklundin merged commit b9fc6e0 into main Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@marklundin marklundin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marklundin @slimbuck