Fix omni lights shadows on WebGPU #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Mar 15, 2024
•
mvaligursky
commented
- We were not specifying fragment shader on WebGPU if we were not writing to any color buffers. That is a problem in cases the fragment shader generates custom depth / handles alpha discard and similar. We now always specify it.
- This fixes omni shadow rendering, as we generate custom depth
- This fixes dithered transparency in pre-pass where only the depth buffer is updated
- enabled clustered omni shadow example for WebGPU
Open
slimbuck
approved these changes
Mar 15, 2024
mvaligursky
added a commit
that referenced
this pull request
Mar 15, 2024
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.