Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the incorrectly exposed PostEffect type parameter #6167

Merged
merged 1 commit into from Mar 15, 2024
Merged

Fix the incorrectly exposed PostEffect type parameter #6167

merged 1 commit into from Mar 15, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 15, 2024 •
edited

Based on #6047

  • further fixes to get it over the line

@mvaligursky mvaligursky self-assigned this Mar 15, 2024
@mvaligursky mvaligursky added bug docs Documentation related labels Mar 15, 2024
@mvaligursky mvaligursky requested a review from a team March 15, 2024 12:19
@mvaligursky mvaligursky merged commit b77a2b3 into main Mar 15, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-post-effect-type branch March 15, 2024 12:37
mvaligursky added a commit that referenced this pull request Mar 15, 2024
@mvaligursky
Fix the incorrectly exposed PostEffect type parameter (#6167)
a861e5d 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
bug docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott