WebXR XRSession.enabledFeatures missing workaround #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
approved these changes
Mar 18, 2024
willeastcott
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebXR Specs are updated periodically and it is up to vendors to keep up with updates.
Despite that, XRSession.enabledFeatures was introduced in the 24 August 2022 spec update, but not all platforms have updated their implementations since, leading to that property missing on some platforms.
This is an unfortunate reality of the web, but we can use alternative paths where it is not available.
This PR does exactly that. Instead of using the
enabledFetaureslist, when it is not available we have to detect if a feature is available in different ways, depending on a specific feature's capabilities. Docs already mention that the availability flag on a feature - does not necessarily available on the session start.Fixes #6045
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.