Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be clear that Node 18+ is required #6284

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Be clear that Node 18+ is required #6284

merged 1 commit into from
Apr 25, 2024

Conversation

willeastcott
Copy link
Contributor

  • Explicitly declare in README that Node 18+ is required.
  • Add a .nvmrc.
  • Add an engines field to the package.json.

Fixes #6236

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin
Copy link
Member

LGTM. Nice one!

@mvaligursky
Copy link
Contributor

Could we also add this to .nvmrc to avoid to have to edit it locally?
registry=https://registry.npmjs.org/

Also, we should do the same for ./examples I think.

@willeastcott
Copy link
Contributor Author

@mvaligursky That goes in .npmrc, not .nvmrc.

@willeastcott willeastcott merged commit 932367a into main Apr 25, 2024
7 checks passed
@willeastcott willeastcott deleted the npm18 branch April 25, 2024 08:41
@kungfooman
Copy link
Collaborator

I used to build the engine on my old Ubuntu VM/server and it doesn't support node v18:

rollup/rollup#5497

There are hundreds of other people with the same issue: https://stackoverflow.com/questions/72921215/getting-glibc-2-28-not-found

The "solution" is "install v16"... software disintegrates quicker than you can fix it these days 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine requires Node 18.0 to build
4 participants