Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for glb load error #6391

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix for glb load error #6391

merged 1 commit into from
May 17, 2024

Conversation

slimbuck
Copy link
Member

Fixes #6389

Looks like this never worked. Multiple root notes were not being handled correctly.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@slimbuck slimbuck requested a review from a team May 17, 2024 08:33
@slimbuck slimbuck self-assigned this May 17, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:36am

@slimbuck slimbuck merged commit 480023f into playcanvas:main May 17, 2024
9 checks passed
@slimbuck slimbuck deleted the glb-fix branch May 17, 2024 08:38
slimbuck added a commit to slimbuck/engine that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: e is not a constructor on loading glb model from ceisium
2 participants