Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build update #28

Merged
merged 3 commits into from Mar 8, 2022
Merged

Build update #28

merged 3 commits into from Mar 8, 2022

Conversation

ellthompson
Copy link
Contributor

This PR brings the build output of PCUI Graph in line with the PCUI library.

  • Exports umd and module builds which contain the pcui and playcanvas observer libs as external dependencies. The UMD build looks for these in the global namespace. The module build imports these libs instead.
  • Included a build that creates the libraries type def file.
  • Declared the main, module, types and files properties in the package.json which allows us to build a standard npm package.
  • Updated the readme

Tested in the shader editor and main PlayCanvas editor

@ellthompson ellthompson added the enhancement New feature or request label Mar 8, 2022
@ellthompson ellthompson requested a review from a team March 8, 2022 16:35
@ellthompson ellthompson self-assigned this Mar 8, 2022
willeastcott
willeastcott reviewed Mar 8, 2022
View reviewed changes
package.json Outdated
"build:bundle": "rollup -c --environment target:bundle",
"build:watch": "rollup -c --environment target:all --watch",
"build:prod": "NODE_ENV=production rollup -c --environment target:all",
"build": "NODE_ENV=production rollup -c --environment target:all",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on Windows. Use cross-env? I believe other repos we have used that.

willeastcott
willeastcott approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 😄 Approving with one comment regarding the package.json.

@ellthompson ellthompson merged commit 0321b33 into main Mar 8, 2022
@ellthompson ellthompson deleted the build-update branch March 8, 2022 16:59
@willeastcott willeastcott mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@ellthompson ellthompson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellthompson @willeastcott