React LabelGroup linking fix #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,13 +16,17 @@ class LabelGroup extends BaseComponent <LabelGroupArgs, any> { | |||
| if (Array.isArray(this.props.children) || !this.props.children) { | |||
| throw new Error('A LabelGroup must contain a single child react component'); | |||
| } | |||
| const labelFieldChild = (this.props.children as { type: any, props: any }); | |||
There was a problem hiding this comment.
Not straightforward to provide types here?
There was a problem hiding this comment.
I've updated the types and included an explanation.
willeastcott
approved these changes
Jan 12, 2023
|
I've updated this PR to include fixes for #270. Re-requesting a review. |
| throw new Error(childrenErrorMessage); | ||
| } | ||
| // casting child as a single ReactElement as we have confirmed it is above | ||
| const child = this.props.children as ReactElement; |
There was a problem hiding this comment.
Why is the name of the property children if it's a single child? Looks a bit odd.
There was a problem hiding this comment.
This children prop is provided by react and includes any child react elements a user has added to their LabelGroup. It's then been limited to a single react element above this line.
willeastcott
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React LabelGroup fields were not being linked to an observer when a link property was passed in. Updates to PCUI components wrapped in a LabelGroup should now correctly update their bound observer.