Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type searchItems function #276

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Type searchItems function #276

merged 5 commits into from
Jan 18, 2023

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 17, 2023 •
edited
Loading

Add types (and docs) for the searchItems function. I've used TypeScript Generics to achieve this. This eliminates 12 any types in the codebase.

Also refactors TreeView and TreeViewItem a little.

@willeastcott willeastcott added the enhancement New feature or request label Jan 17, 2023
@willeastcott willeastcott requested a review from a team January 17, 2023 00:23
@willeastcott willeastcott self-assigned this Jan 17, 2023
@willeastcott willeastcott merged commit a8f52b3 into main Jan 18, 2023
@willeastcott willeastcott deleted the type-search branch January 18, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeastcott @slimbuck