Remove _treeOrder member from TreeViewItem
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
TreeViewtagsTreeViewIteminstances with a number representing the depth first order of the item in the tree. This happens whenever a drag of aTreeViewItemends. Since this member is protected,@ts-ignores are needed to silence the TypeScript compiler errors.This PR refactors the code to no longer have to tag
TreeViewItems with the order number. Instead, it creates a temporaryMapofTreeViewItemtonumber(order).This removes another 2
@ts-ignores and makes theTreeViewItemset of member variables that little bit cleaner. There are only 34@ts-ignores left in the codebase.