Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit empty interfaces in the codebase #292

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Prohibit empty interfaces in the codebase #292

merged 2 commits into from
Jan 23, 2023

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 23, 2023 •
edited
Loading

The Divider element needlessly extends the ElementArgs interface when the constructor could just accept ElementArgs. Enabled the ESLint rule @typescript-eslint/no-empty-interface to prevent this in future.

@willeastcott willeastcott added the enhancement New feature or request label Jan 23, 2023
@willeastcott willeastcott self-assigned this Jan 23, 2023
@willeastcott willeastcott merged commit 3443e37 into main Jan 23, 2023
@willeastcott willeastcott deleted the no-empty-interfaces branch January 23, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellthompson ellthompson ellthompson approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@willeastcott willeastcott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeastcott @ellthompson