Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor element registry #302

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Refactor element registry #302

merged 3 commits into from
Jan 30, 2023

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 28, 2023 •
edited
Loading

This PR:

  • Switches the element registry from a vanilla object to a Map.
  • Swaps the use of Object.assign to the spread operator.
  • Adds missing @returns tag for Element.create.

@willeastcott willeastcott added the enhancement New feature or request label Jan 28, 2023
@willeastcott willeastcott self-assigned this Jan 28, 2023
@willeastcott willeastcott merged commit 301b0da into main Jan 30, 2023
@willeastcott willeastcott deleted the element-registry branch January 30, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@ellthompson ellthompson Awaiting requested review from ellthompson

Assignees

@willeastcott willeastcott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeastcott @slimbuck