Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class tracking #311

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fix class tracking #311

merged 1 commit into from
Mar 31, 2023

Conversation

slimbuck
Copy link
Member

React components weren't removing classes from elements once they were added.

This PR tracks the classes correctly and makes use of Sets instead of arrays.

@slimbuck slimbuck added the bug Something isn't working label Mar 31, 2023
@slimbuck slimbuck requested a review from a team March 31, 2023 11:16
@slimbuck slimbuck self-assigned this Mar 31, 2023
@slimbuck slimbuck merged commit 82bcea0 into main Mar 31, 2023
@slimbuck slimbuck deleted the class-fix branch March 31, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellthompson ellthompson ellthompson approved these changes

Assignees

@slimbuck slimbuck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slimbuck @ellthompson