Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stories files #328

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Rename stories files #328

merged 2 commits into from
Sep 3, 2023

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Sep 3, 2023

In each component folder, we currently have:

  • index.ts (the PCUI element source)
  • component.tsx (the React wrapper for the PCUI element)
  • index.stories.tsx (the Storybook stories for the React wrapped component)

It seems to me that index.stories.tsx would be better named component.stories.tsx since it's operating on/exercising component.tsx.

@willeastcott willeastcott added the enhancement New feature or request label Sep 3, 2023
@willeastcott willeastcott self-assigned this Sep 3, 2023
@willeastcott willeastcott merged commit c2e1a60 into main Sep 3, 2023
6 checks passed
@willeastcott willeastcott deleted the index-to-component branch September 3, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant