177/ add plugin examples and managed player to demo app #215
Conversation
| } | ||
|
|
||
| var playerListSection: some View { | ||
| List { |
There was a problem hiding this comment.
These utilities are published for consuming users to use, this would mean that all users using the utility will now have a section for these hardcoded managedplayer flows if they were to use this.
This will need to be refactored so that we can show those flows in our demo app, using the same tools we publish for consuming users. But we do not want to include our plugin examples in other users demo/example apps.
In my mind, we would not have changed AssetCollectionView, we would provide an additional utility to setup more specific flows, and have it use AssetCollectionView to display the asset flows as it does today.
ios/packages/test-utils/Sources/ui-test/SegmentControlView.swift
Outdated
Show resolved
Hide resolved
ios/packages/test-utils/Sources/ui-test/SegmentControlView.swift
Outdated
Show resolved
Hide resolved
ios/packages/test-utils/Sources/ui-test/String + Extensions.swift
Outdated
Show resolved
Hide resolved
String + Extensions.swift
Outdated
| @@ -0,0 +1,156 @@ | |||
| // | |||
There was a problem hiding this comment.
this looks like a duplicate file, and is at the repo root, should probably be removed
|
|
||
| import Foundation | ||
|
|
||
| public class MockFlowManager: FlowManager { |
There was a problem hiding this comment.
Came back in the rebase?
| @@ -50,7 +50,7 @@ open class AssetUITestCase: XCTestCase { | |||
| - mockName: The name of the mock to open | |||
| */ | |||
| open func openFlow(_ mockName: String) { | |||
| navigateToAssetCollection() | |||
|
|
|||
There was a problem hiding this comment.
probably shouldnt be removed, we can just not use super in the override location
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorVersion
Published prerelease version:
0.4.5-next.2Changelog
馃悰 Bug Fix
馃彔 Internal
Authors: 9