Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error messaging for failed expression eval and parsing #239

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

adierkens
Copy link
Member

@adierkens adierkens commented Nov 16, 2023

Now provides both the source of the error and the context for the expression that failed
CleanShot 2023-11-16 at 09 43 20

Release Notes

Improved error messages for parse and eval failures for expressions

@adierkens adierkens added the patch Increment the patch version when merged label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c92e13f) 82.21% compared to head (36c1887) 82.16%.
Report is 16 commits behind head on main.

Files Patch % Lines
core/player/src/expressions/evaluator.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   82.21%   82.16%   -0.06%     
==========================================
  Files         132      132              
  Lines        4544     4546       +2     
  Branches     1118     1119       +1     
==========================================
- Hits         3736     3735       -1     
- Misses        531      534       +3     
  Partials      277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adierkens adierkens merged commit f5b1f77 into main Nov 16, 2023
13 of 15 checks passed
@adierkens adierkens deleted the expression-error-messages branch November 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants