Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set applitools env variables for iOS tests #27

Merged
merged 11 commits into from
Aug 10, 2022
Merged

set applitools env variables for iOS tests #27

merged 11 commits into from
Aug 10, 2022

Conversation

hborawski
Copy link
Contributor

No description provided.

@hborawski hborawski added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Jul 27, 2022
@@ -137,7 +137,7 @@ jobs:
- run: cd xcode && bundle exec pod install
- run: bazel build --config=ci --remote_header=x-buildbuddy-api-key=${BUILDBUDDY_API_KEY} -- //:PlayerUI //:PlayerUI-Demo //:PlayerUI_Pod
# TODO: the timeout should be added to the test itself
- run: bazel test --test_timeout=600 --jobs=1 --verbose_failures --config=ci --remote_header=x-buildbuddy-api-key=${BUILDBUDDY_API_KEY} -- //:PlayerUI-Unit-Unit //:PlayerUI-UI-ViewInspectorTests //:PlayerUI-UI-XCUITests
- run: APPLITOOLS_API_KEY=${APPLITOOLS_KEY} APPLITOOLS_BATCH_ID=${CIRCLE_BUILD_NUM} bazel test --test_timeout=600 --jobs=1 --verbose_failures --config=ci --remote_header=x-buildbuddy-api-key=${BUILDBUDDY_API_KEY} -- //:PlayerUI-Unit-Unit //:PlayerUI-UI-ViewInspectorTests //:PlayerUI-UI-XCUITests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should set APPLITOOLS_BATCH_ID to CIRCLE_SHA1 to make it work with the GH plugin:
Screen Shot 2022-07-27 at 5 06 11 PM

https://applitools.com/docs/topics/integrations/github-integration-ci-setup.html#how-to-prepare-your-code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh i forgot we can use that now in OSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants