Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Types Plugin restoring old dataRefs #302

Merged
merged 11 commits into from
Mar 6, 2024
Merged

Conversation

lexfm
Copy link
Contributor

@lexfm lexfm commented Feb 16, 2024

Change Type (required)

  • Reverted common-types plugin dataRefs. Those can now be dynamically created when generating the dynamic types for the DSLSchema.
  • Generating and exporting dataRefs, validationRefs and DSLSchema Type from @player-ui/reference-assets-components.
  • patch
  • minor
  • major

Version

Published prerelease version: 0.7.2-next.0

Changelog

🐛 Bug Fix

Authors: 3

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (b0282a1) to head (1c14593).
Report is 18 commits behind head on main.

❗ Current head 1c14593 differs from pull request most recent head 20c3e7e. Consider uploading reports for the commit 20c3e7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   81.95%   81.93%   -0.03%     
==========================================
  Files         134      133       -1     
  Lines        4622     4616       -6     
  Branches     1140     1140              
==========================================
- Hits         3788     3782       -6     
  Misses        553      553              
  Partials      281      281              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member

We should be generating and exporting dataRefs for these types (and probably re-exporting them in the @player-ui/reference-assets-components package) to showcase our preferred approach for setting up authoring capabilities.

@KetanReddy KetanReddy self-requested a review February 24, 2024 21:14
@KetanReddy KetanReddy added the patch Increment the patch version when merged label Feb 24, 2024
@KetanReddy
Copy link
Member

Can we also export the validations from the common-type plugin and export a DSLSchema type to tie it all together

@lexfm lexfm merged commit bc01b43 into main Mar 6, 2024
9 checks passed
@lexfm lexfm deleted the Plugin/CommonTypes/DataRefs branch March 6, 2024 00:14
@intuit-svc intuit-svc mentioned this pull request Apr 10, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants