read sha as batch id #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brocollie08
reviewed
Jul 28, 2022
| @@ -23,6 +23,8 @@ abstract class ApplitoolsTest { | |||
| Eyes().apply { | |||
| componentsProvider = AndroidXComponentsProvider() | |||
| configuration = Configuration().apply { | |||
| appName = "Android Reference Assets" | |||
| addProperty("platform", "android") | |||
| batch = batchInfo | |||
| apiKey = ApplitoolsConfig.APPLITOOLS_KEY | |||
There was a problem hiding this comment.
you gonna try removing this in this PR?
There was a problem hiding this comment.
applitools support and i agreed, that since what we have works, it's not entirely worth it to figure out why we can't just pull from the environment.. i thought that maybe it had to do with those env vars not existing within the emulator, but not entirely sure.. regardless, i was a little skeptical anyways
sugarmanz
force-pushed
the
applitools-gh-plugin
branch
from
41b15d3
to
184fa06
Compare
This was referenced Jul 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.