iOS: expose data controller onUpdate hook #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborawski
reviewed
Apr 11, 2024
Comment on lines
129
to
130
| let hookValue = try? JSONDecoder().decode(T.self, from: val), | ||
| let hookValue2 = try? JSONDecoder().decode(U.self, from: val2) |
There was a problem hiding this comment.
probably trivial perf, but we can just make one decoder and reuse it
|
|
||
| public struct Update: Decodable { | ||
| /** The updated binding */ | ||
| var binding: BindingInstance |
There was a problem hiding this comment.
can you add a regression test also to make sure that binding is decoded properly with a value?
hborawski
approved these changes
Apr 11, 2024
This was referenced Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose on update hook so Swift plugins can recieve data changes
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?
Version
Published prerelease version:
0.7.3-next.0Changelog
馃悰 Bug Fix
Authors: 2