Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive binding with opening { #342

Merged
merged 1 commit into from
May 3, 2024

Conversation

DukeManh
Copy link
Contributor

@DukeManh DukeManh commented Apr 21, 2024

Fix #157. Require two adjacent { for a binding.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.7.4-next.0

Changelog

🐛 Bug Fix

Authors: 1

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (e3d95ae) to head (d878180).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   81.90%   81.91%   +0.01%     
==========================================
  Files         133      133              
  Lines        4619     4618       -1     
  Branches     1142     1141       -1     
==========================================
  Hits         3783     3783              
  Misses        555      555              
+ Partials      281      280       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spentacular spentacular merged commit cef2a5f into player-ui:main May 3, 2024
9 checks passed
@spentacular
Copy link
Contributor

@DukeManh Thanks so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial { of binding can be swallowed, causing a false positive binding
2 participants