Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Twitter bootstrap helper #834

Closed
jroper opened this issue Mar 12, 2013 · 7 comments
Closed

Deprecate the Twitter bootstrap helper #834

jroper opened this issue Mar 12, 2013 · 7 comments

Comments

@jroper
Copy link
Member

jroper commented Mar 12, 2013

The Twitter bootstrap form template helper wasn't updated since a year and does not yet fully support Bootstrap 2.
In a pull request guillaumebort suppose to deprecated the helper in the next Play version (and publish a Plugin for the helper?).

But in Play 2.1 the Play Template helper Documentation still suppose to use the Twitter template helper and there is no note that Bootstrap 2 isn't fully supported which is frustrating for newbies like me.
@Gissues:{"order":66.6666666666666,"status":"backlog"}

@ndeverge
Copy link
Member

First, I'd remove or deprecate the paragraph from the documentation.

danielberndt pushed a commit to patiencelabs/Play20 that referenced this issue Mar 13, 2013
danielberndt pushed a commit to patiencelabs/Play20 that referenced this issue Mar 13, 2013
@huntc
Copy link
Contributor

huntc commented Jun 25, 2013

Probably should also be factored out of the core of Play as well.

@wsargent
Copy link
Member

wsargent commented Jul 9, 2013

I can take this -- I'll refactor it out of Play Core, mark it deprecated and move the documentation out.

@wsargent
Copy link
Member

wsargent commented Aug 8, 2013

Most of the work is done, but there are some outstanding jQuery issues in the "forms" sample applications. https://github.com/philipmjohnson/play-form-kludge looks like an interesting approach as well.

@wsargent
Copy link
Member

jQuery issues fixed.

@wsargent
Copy link
Member

Needs a note in the migration guide as well.

@jroper jroper removed this from the 2.3.0 milestone Apr 8, 2014
@benmccann benmccann added this to the 2.4.0 milestone Feb 26, 2015
@benmccann
Copy link
Contributor

The Play 2.3 migration guide mentions this has already been deprecated: https://www.playframework.com/documentation/2.3.x/Migration23

Closing this issue as addressed

@benmccann benmccann modified the milestones: 2.3.0, 2.4.0 Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants