Skip to content

Commit

Permalink
Make JsBoolean extend Function1 instead of AbstractFunction1 (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
gmethvin committed Apr 22, 2017
1 parent 749f079 commit c7d4ee2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions build.sbt
Expand Up @@ -41,9 +41,12 @@ import com.typesafe.sbt.SbtScalariform._
import scalariform.formatter.preferences._

val previousVersion = Def.setting[Option[String]] {
if (scalaVersion.value startsWith "2.11") Some("2.5.12")
else if (scalaVersion.value startsWith "2.10") None
else Some("2.6.0-M1")
scalaVersion.value.split('.')(1) match {
case "10" => Some("2.6.0-M6")
case "11" => Some("2.5.14")
case "12" => Some("2.6.0-M1")
case _ => None
}
}

lazy val playJsonMimaSettings = mimaDefaultSettings ++ Seq(
Expand Down Expand Up @@ -90,7 +93,6 @@ val compatFilters = {
Seq(
validationFilter,
ProblemFilters.exclude[MissingClassProblem]("play.libs.Json"),
ProblemFilters.exclude[AbstractClassProblem]("play.api.libs.json.JsBoolean"),
ProblemFilters.exclude[DirectMissingMethodProblem]("play.api.libs.json.ConstraintReads.min"),
ProblemFilters.exclude[DirectMissingMethodProblem]("play.api.libs.json.ConstraintReads.max"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("play.api.libs.json.Reads.min"),
Expand Down
2 changes: 1 addition & 1 deletion play-json/shared/src/main/scala/JsValue.scala
Expand Up @@ -68,7 +68,7 @@ case object JsTrue extends JsBoolean(true)
*/
case object JsFalse extends JsBoolean(false)

object JsBoolean extends scala.runtime.AbstractFunction1[Boolean, JsBoolean] {
object JsBoolean extends Function1[Boolean, JsBoolean] {
def apply(value: Boolean): JsBoolean = value match {
case true => JsTrue
case false => JsFalse
Expand Down

0 comments on commit c7d4ee2

Please sign in to comment.