Utility to convert JsResult to Try

[cchantep]

def foo[T](res: JsResult[T]): Try[T] = JsResult.toTry(res)
def bar[T](res: JsResult[T]): Future[T] = Future.fromTry(JsResult.toTry(res))

[gmethvin]

Why IllegalArgumentException? RuntimeException would probably be fine.

[cchantep]

Illegal argument makes more sense, since raised when input data cannot be validated.

[gmethvin]

I'm just not clear on which method is being passed an invalid argument. See https://docs.oracle.com/javase/8/docs/api/java/lang/IllegalArgumentException.html:

Thrown to indicate that a method has been passed an illegal or inappropriate argument.

[cchantep]

.validate is passed an invalid JSON argument in this case

[gmethvin]

Normally you'd use IllegalArgumentException to indicate that input arguments are malformed in some way. It generally indicates a programmer error. I've never seen it used when validating user input and I don't think a typical Scala user would expect that either.

[gmethvin]

Also, it might be nice to add a toJson method on the exception to make it easy to convert to a result:

lazy val toJson: JsValue = JsError.toJson(cause)

exception.toJson is a lot clearer than JsError.toJson(exception.cause).

[cchantep]

"typical Scala user would expect that either." That's not the point, as the Scala dev will sees it's a JsError.Exception, which is quite explicit for me.

The .toJson is not useful, as the Exception will be in case of conversion from JSON validation to Try. The .toJson is only useful when considering the error as validation error.

[gmethvin]

s/results/result/

[cchantep]

Updated

[gmethvin]

Maybe this should be in JsError? i.e. JsError.Exception is an exception produced from a JsError.

[cchantep]

Updated

[cchantep]

thx