Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Scala 3.0.0-RC1 to crossbuild #571

Merged
merged 2 commits into from Feb 18, 2021

Conversation

SethTisue
Copy link
Member

partially addresses #570

@SethTisue
Copy link
Member Author

@dwijnand you might know what this is about...?

[error] -- Error: /home/travis/build/playframework/play-json/play-json/shared/src/test/scala/play/api/libs/json/MacroSpec.scala:106:52 
[error] 106 |      implicit val familyReads: Reads[Family]     = Json.reads[Family]
[error]     |                                                    ^^^^^^^^^^^^^^^^^^
[error]     |cannot reduce summonFrom with
[error]     | patterns :  case t @ 
[error]     |  _:
[error]     |    
[error]     |      play.api.libs.json.Reads[play.api.libs.json.MacroSpec.Lorem[Any] & 
[error]     |        play.api.libs.json.MacroSpec.Family
[error]     |      ]
[error]     |    
[error]     | This location contains code that was inlined from package.scala:144
[error]     | This location contains code that was inlined from JsMacroImpl.scala:122
[error]     | This location contains code that was inlined from JsMacroImpl.scala:81
[error]     | This location contains code that was inlined from JsMacroImpl.scala:82
[error]     | This location contains code that was inlined from JsMacroImpl.scala:52
[error]     | This location contains code that was inlined from JsMacroImpl.scala:22
[error]     | This location contains code that was inlined from JsMacros.scala:28

@@ -2,5 +2,5 @@ object Dependencies {
// scalaVersion needs to be kept in sync with travis-ci
val Scala212 = "2.12.13"
val Scala213 = "2.13.4"
val Scala3 = "3.0.0-M3"
val Scala3 = Seq("3.0.0-M3", "3.0.0-RC1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why M3 as well?

Copy link
Member Author

@SethTisue SethTisue Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be convenient for downstream maintainers to publish for the last two versions, so that people can take the library version bump separately from the Scala version bump, to help narrow down the number of possible causes if something goes wrong

@dwijnand regardless, if keeping M3 makes any trouble for supporting RC1, it is totally fine with me to just drop M3

@dwijnand
Copy link
Member

@dwijnand you might know what this is about...?

[error] -- Error: /home/travis/build/playframework/play-json/play-json/shared/src/test/scala/play/api/libs/json/MacroSpec.scala:106:52 
[error] 106 |      implicit val familyReads: Reads[Family]     = Json.reads[Family]
[error]     |                                                    ^^^^^^^^^^^^^^^^^^
[error]     |cannot reduce summonFrom with
[error]     | patterns :  case t @ 
[error]     |  _:
[error]     |    
[error]     |      play.api.libs.json.Reads[play.api.libs.json.MacroSpec.Lorem[Any] & 
[error]     |        play.api.libs.json.MacroSpec.Family
[error]     |      ]
[error]     |    
[error]     | This location contains code that was inlined from package.scala:144
[error]     | This location contains code that was inlined from JsMacroImpl.scala:122
[error]     | This location contains code that was inlined from JsMacroImpl.scala:81
[error]     | This location contains code that was inlined from JsMacroImpl.scala:82
[error]     | This location contains code that was inlined from JsMacroImpl.scala:52
[error]     | This location contains code that was inlined from JsMacroImpl.scala:22
[error]     | This location contains code that was inlined from JsMacros.scala:28

Lorem <: Family and there definitely is an instance of Reads[Lorem[Any]] in scope, so you'd expect that it can summon an instance of Reads[Lorem[Any] & Family] and indeed it did in M3. Is it not intentional or not? I'm 98% sure I can work around it, but is it a regression? A blocking one? 🤷🏼‍♂️

@SethTisue SethTisue marked this pull request as ready for review February 18, 2021 04:23
@SethTisue
Copy link
Member Author

thanks for figuring this out, Dale.

this appears to be ready for merge.

@dwijnand dwijnand merged commit 64c78f3 into playframework:master Feb 18, 2021
@SethTisue SethTisue deleted the scala-3.0.0-RC1 branch February 18, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants