Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scala version settings #794

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 2, 2022

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Purpose

use semantic version selector for scala version settings in github actions.

Background Context

References

https://github.com/sbt/sbt/releases/tag/v1.7.0

++ command updates
Prior to sbt 1.7 ++ filtered subprojects using crossScalaVersions having the same ABI suffix as . This behavior was generally not well understood, and also created incorrect result for Scala 3.x since ++ 3.0.1 test could downgrade subproject that may require 3.1 or above.

sbt 1.7.0 fixes this by requiring ++ so part can be given as a semantic version selector expression, such as 3.1.x or 2.13.x. Note that the expression may match at most one Scala version to switch into. In sbt 1.7.0, a concrete version such as ++ 3.0.1 equires exact version to be present in crossScalaVersion.

@xuwei-k xuwei-k marked this pull request as ready for review October 2, 2022 07:18
Copy link
Member

@ihostage ihostage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thank you, @xuwei-k! 👍

@@ -38,7 +38,7 @@ jobs:
uses: playframework/.github/.github/workflows/cmd.yml@v3
with:
java: 17, 11
scala: 2.12.16, 2.13.8, 3.2.0
scala: 2.12.x, 2.13.x, 3.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, just saw the PR description.

@ihostage
Copy link
Member

ihostage commented Oct 3, 2022

@mkurz I think we should do that for other repos where it will be possible ☝️

@mkurz
Copy link
Member

mkurz commented Oct 3, 2022

@ihostage I will release a Play milestone and will upgrade all repos with it, while doing that I can also update the workflow.

@mkurz mkurz merged commit 1d128d3 into playframework:main Oct 3, 2022
@xuwei-k xuwei-k deleted the semantic-version-selector branch October 3, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants