Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala3-compiler, scala3-library, ... 3.3.0-RC5 (was 3.2.0) #848

Merged

Conversation

scala-steward
Copy link
Contributor

Updates

from 3.2.0 to 3.2.2.
GitHub Release Notes - Version Diff - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@mergify mergify bot added the type:updates label Feb 4, 2023
@mkurz mkurz changed the title scala3-compiler, scala3-library, ... 3.2.2 (was 3.2.0) scala3-compiler, scala3-library, ... 3.3.0-RC5 (was 3.2.0) May 4, 2023
@mkurz mkurz force-pushed the update/scala3-compiler-3.2.2 branch from 97019d0 to 5a339b5 Compare May 4, 2023 10:01
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we are able to upgrade to Scala 3.3.0...

@@ -11,21 +11,14 @@ final class EnumSpec extends AnyWordSpec with Matchers {
"EnumFormat" should {
import TestEnums.EnumWithDefaultNames._

// https://gitter.im/lampepfl/dotty?at=5ee22d1e7b6da9126a8b4a51 ¯\_(ツ)_/¯
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't access that chat log anymore but it it looks like the problem is now fixed 😉

@@ -46,7 +46,7 @@ class JsonMemoryFootprintSpec extends AnyFreeSpec {
"obj0" in assertSizes(arr1KB("{}"), 7432, 7432)
"obj1" in assertSizes(arr1KB("""{"a":6}"""), 29568, 31568)
"nums" in assertSizes(arr1KB("6"), 42104, 42104)
"arr0" in assertSizes(arr1KB("[]"), 42064, 42064)
"arr0" in assertSizes(arr1KB("[]"), 15424, 15424)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The memory footprint decreased between Scala 3.2.1-RC3 and RC4: scala/scala3@3.2.1-RC3...3.2.1-RC4
(yes I did track this down). Seems like bumping the stdlib from 2.13.8 to 2.13.10 had some performance improvements positively effecting memory usage. I am not going to track down which commit exactly caused this (scala/scala@ef5a758 would be a candidate but not sure)

@mkurz mkurz merged commit fb8974f into playframework:main May 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants