remove deprecated JsBoolean methods #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchantep
reviewed
Mar 28, 2023
| @@ -51,6 +51,16 @@ def playJsonMimaSettings = Seq( | |||
| case _ => throw new Error("Unable to determine previous version") | |||
| }), | |||
| mimaBinaryIssueFilters ++= Seq( | |||
| // remove deprecated methods | |||
| // https://github.com/playframework/play-json/pull/861 | |||
| ProblemFilters.exclude[DirectMissingMethodProblem]("play.api.libs.json.JsBoolean.productArity"), | |||
There was a problem hiding this comment.
Maybe we could bump the mimaPreviousVersion instead ?
There was a problem hiding this comment.
Bump to what? IMHO it's ok to add those filters here. Thanks!
There was a problem hiding this comment.
I bumping mimaPreviousArtifacts is sufficient, it's much better than adding those filters
mkurz
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
JsBooleanon Scala 3:productElementNamesthrow an java.lang.IndexOutOfBoundsException: 0 exception #859Purpose
remove deprecated JsBoolean methods
Background Context
maybe
val productArity = 1causeIndexOutOfBoundsExceptionon Scala 3.References