Bounce address

[kpmeen]

Added support for setting a custom bounce address as specified in commons mail (here: http://commons.apache.org/proper/commons-email/userguide.html#Handling_Bounced_Messages).

[ggrossetie]

Hi @kpmeen,

Thank you for your contribution. Would you mind signing our CLA?

http://www.typesafe.com/contribute/cla

Thanks!

[ggrossetie]

Can you use data.bounceAddress.foreach(email.setBounceAddress) to stay consistent with the rest of the code ?

[ggrossetie]

Could you do a rebase to avoid the merge commit 426a734 ?

[kpmeen]

Thanks for swift feedback! Updated and pushed :-)

[jroper]

lgtm

[ggrossetie]

Yep 👍

[ggrossetie]

Great work, thanks again!

[mkurz]

@Mogztter Could it be that for adding the bounce address we also could run into encoding problems like #28? Shouldn't setAddress also get called here? I am not sure, I was just thinking about it during reviewing the code...

[ggrossetie]

AFAIK there's only one method to set the bounce address:
https://commons.apache.org/proper/commons-email/apidocs/org/apache/commons/mail/Email.html#setBounceAddress(java.lang.String)

This means that you are not supposed to define a name (just an email
address).
If we define a name and an email I think we will have encoding problems...
We need to add a test to verify that assertion and open an issue in commons
mailer ;)
Le 19 mai 2015 9:30 AM, "Matthias Kurz" notifications@github.com a écrit :

@Mogztter https://github.com/Mogztter Could it be that for adding the
bounce address
https://github.com/playframework/play-mailer/blob/master/src/main/scala/play/api/libs/mailer/MailerPlugin.scala#L134
we also could run into encoding problems like #28
#28? Shouldn't
setAddress also get called here? I am not sure, I was just thinking about
it during reviewing the code...

—
Reply to this email directly or view it on GitHub
#25 (comment)
.