Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateCode and formatCode helpers #252

Open
3 of 21 tasks
mkurz opened this issue Oct 25, 2022 · 1 comment
Open
3 of 21 tasks

validateCode and formatCode helpers #252

mkurz opened this issue Oct 25, 2022 · 1 comment

Comments

@mkurz
Copy link
Member

mkurz commented Oct 25, 2022

Does not have validateCode (and therefore also no formatCode)

That might also mean these repos do not even pull in scalafmt.

These I am not sure about because they are seed projects. We can add formatting but I don't think scalafmt should be included when running sbt new ...

In play-samples sbt <command> will not work, because in this repo is the mothership for a lot of projects.
We probably would need something like the test.sh script which goes into each project, and runs the sbt command (like validateCode.sh and formatCode.sh:

Has validateCode but no formatCode

@mkurz
Copy link
Member Author

mkurz commented Jan 24, 2023

@ihostage Look at playframework/playframework#11513, I tried to come up with a solution how we can sync the same files everywhere and using sys properties as for a repo's special needs. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Play Community Board
  
In progress
Development

No branches or pull requests

1 participant