Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play java with Akka Cluster example #109

Merged
merged 13 commits into from
Sep 7, 2020
Merged

Play java with Akka Cluster example #109

merged 13 commits into from
Sep 7, 2020

Conversation

ignasi35
Copy link
Member

No description provided.

patriknw
patriknw reviewed Sep 1, 2020
View reviewed changes
Copy link

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

play-java-akka-cluster-example/build.sbt Outdated Show resolved Hide resolved
play-java-akka-cluster-example/conf/logback.xml Show resolved Hide resolved
play-java-akka-cluster-example/project/plugins.sbt Outdated Show resolved Hide resolved
@ignasi35 ignasi35 marked this pull request as ready for review September 1, 2020 10:48
@ignasi35
Copy link
Member Author

ignasi35 commented Sep 1, 2020 •
edited

Notice the copy/pasting from multiple sources: the CouternActor from akka docs (cluster singleton section), and the config files from `akka-microsevices-seed-scala.g8.

@ignasi35 ignasi35 self-assigned this Sep 2, 2020
patriknw
patriknw approved these changes Sep 2, 2020
View reviewed changes
Copy link

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'd still suggest <logger name="akka" level="INFO" />, since cluster logging gives enough information on INFO level.

@ignasi35 ignasi35 requested review from raboof and removed request for raboof September 7, 2020 10:50
@ignasi35 ignasi35 merged commit fcef009 into playframework:2.8.x Sep 7, 2020
@ignasi35 ignasi35 deleted the play-java-cluster-example branch September 7, 2020 10:51
@mkurz mkurz mentioned this pull request Nov 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees

@ignasi35 ignasi35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignasi35 @patriknw