Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9.x] Publish sources of examples as separated artifacts are attached to pre-release (backport #569) by @ihostage #571

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 4, 2024

This is an automatic backport of pull request #569 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mkurz
Copy link
Member

mkurz commented Mar 4, 2024

We can merge, the added worklow will not even run for on: pull_request, so it's non-op 😉

@mkurz mkurz merged commit 43dd9ea into 2.9.x Mar 4, 2024
16 checks passed
@mkurz mkurz deleted the mergify/bp/2.9.x/pr-569 branch March 4, 2024 20:51
@mkurz
Copy link
Member

mkurz commented Mar 4, 2024

👍 https://github.com/playframework/play-samples/releases/tag/v2.9.x

@ihostage
Copy link
Member

ihostage commented Mar 4, 2024

Tadaaaam... We can use this archives in Play documentation now 🕺
For example we can change now all links on this page https://www.playframework.com/documentation/3.0.x/Tutorials 😄

@mkurz
Copy link
Member

mkurz commented Mar 4, 2024

Tadaaaam... We can use this archives in Play documentation now 🕺 For example we can change now all links on this page https://www.playframework.com/documentation/3.0.x/Tutorials 😄

Yes 👍 If you have time... can you open a PR to the .com (sorry main repo) repo and update the links 😉? (just if you have time sometimes) And change "Link" to "Download (zip)" (like it was in https://www.playframework.com/documentation/2.8.x/Tutorials). (We do not need a link to GitHub in each row, just the zip download IMHO is enough. I will modify the text above on that page to fit the table then (and also link the the github repo, which currently is already linked)

Also, not sure if this is even possible, but maybe we can do something like this tabs, like here for pekko/akka (not sure however if this is just for code snippets or if we can put any content inside):

WDYT?

@mkurz
Copy link
Member

mkurz commented Mar 4, 2024

Tadaaaam... We can use this archives in Play documentation now 🕺

Also this was really a good idea, thanks!

@ihostage
Copy link
Member

ihostage commented Mar 5, 2024

Yes 👍 If you have time... can you open a PR to the .com (sorry main repo) repo and update the links 😉? (just if you have time sometimes) And change "Link" to "Download (zip)" (like it was in https://www.playframework.com/documentation/2.8.x/Tutorials). (We do not need a link to GitHub in each row, just the zip download IMHO is enough. I will modify the text above on that page to fit the table then (and also link the the github repo, which currently is already linked)

Yes, I'll try 😉

Also, not sure if this is even possible, but maybe we can do something like this tabs, like here for pekko/akka (not sure however if this is just for code snippets or if we can put any content inside):

WDYT?

Definitely, we will can do that in Antora as same as we already done with Play gRPC docs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants