Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.9 Support #39

Closed
nemoo opened this issue Oct 9, 2023 · 4 comments · Fixed by #40
Closed

Play 2.9 Support #39

nemoo opened this issue Oct 9, 2023 · 4 comments · Fixed by #40

Comments

@nemoo
Copy link

nemoo commented Oct 9, 2023

I tried to use a naked play 2.9 template taken from sbt new playframework/play-scala-seed.g8 --branch 2.9.x with Silhouette 8.0.2.
When I try to compile it, the compile fails with:

[error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error] 	* org.scala-lang.modules:scala-xml_2.13:2.2.0 (early-semver) is selected over 1.2.0
[error] 	    +- com.typesafe.play:twirl-api_2.13:1.6.1             (depends on 2.2.0)
[error] 	    +- com.typesafe.play:play-ws-standalone-xml_2.13:2.1.10 (depends on 1.2.0)
[error] 

@nemoo nemoo changed the title PLay 2.9 Support Play 2.9 Support Oct 9, 2023
@brkaisin
Copy link

brkaisin commented Oct 18, 2023

I tried to use a naked play 2.9 template taken from sbt new playframework/play-scala-seed.g8 --branch 2.9.x with Silhouette 8.0.2. When I try to compile it, the compile fails with:

[error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error] 	* org.scala-lang.modules:scala-xml_2.13:2.2.0 (early-semver) is selected over 1.2.0
[error] 	    +- com.typesafe.play:twirl-api_2.13:1.6.1             (depends on 2.2.0)
[error] 	    +- com.typesafe.play:play-ws-standalone-xml_2.13:2.1.10 (depends on 1.2.0)
[error] 

This can be avoided by adding this dependency explicitly:
"com.typesafe.play" %% "play-ws-standalone-xml" % "2.2.3"

However, this could still crash at runtime.

@dejvid
Copy link

dejvid commented Nov 14, 2023

Will this be published for play 2.9/3.0? We really need this feature.

@mkurz
Copy link
Member

mkurz commented Nov 14, 2023

Will this be published for play 2.9/3.0? We really need this feature.

Yes, please be patient 😉

@mkurz mkurz closed this as completed in #40 Nov 20, 2023
@mkurz
Copy link
Member

mkurz commented Dec 9, 2023

version 9.0.0 with support for Play 2.9 is released now: https://github.com/playframework/play-silhouette/releases/tag/9.0.0
version 10.0.0 with support for Play 3.0 should follow very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants