Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silhouette pekko based with Play 3 #68

Merged
merged 1 commit into from Dec 9, 2023
Merged

Silhouette pekko based with Play 3 #68

merged 1 commit into from Dec 9, 2023

Conversation

MathisGuillet1
Copy link
Contributor

A contribution to be able to also release a version based on Play 3 with Pekko

@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 7140787726

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.464%

Totals Coverage Status
Change from base Build 7140780258: 0.0%
Covered Lines: 1365
Relevant Lines: 1445

💛 - Coveralls

@mkurz
Copy link
Member

mkurz commented Nov 20, 2023

Thanks, this has to wait a bit. Scala 3 support needs to be done first, then we can make the switch.

@mkurz
Copy link
Member

mkurz commented Dec 8, 2023

@MathisGuillet1 Can you rebase that for me? Thanks!

@MathisGuillet1
Copy link
Contributor Author

@MathisGuillet1 Can you rebase that for me? Thanks!

@mkurz I'm on it.

I also want to make sure before merging it that we create a protected branch dedicated to play 2.9 and akka to make sure everyone can benefit from the lib wether they stick with play 2.9 or 3.0

@mkurz
Copy link
Member

mkurz commented Dec 8, 2023

I also want to make sure before merging it that we create a protected branch dedicated to play 2.9 and akka to make sure everyone can benefit from the lib wether they stick with play 2.9 or 3.0

Yes sure, first the 2.9 thing, doing the 2.9.x dedicated branch and afterwards merging this PR.

@mkurz
Copy link
Member

mkurz commented Dec 8, 2023

@MathisGuillet1 @ndeverge So we are almost there, however I am on a train and need to get out in a couple of minutes for a meeting. On my ride back in the evening (which will take like 2,5 hours) I will finish setting up the release process and switch to our github actions workflows, shouldn't take too long. Thanks for the patience!

@mkurz mkurz force-pushed the play-3-pekko branch 4 times, most recently from 564d65f to d4225d5 Compare December 8, 2023 20:16
@mkurz mkurz merged commit 651b2cc into main Dec 9, 2023
18 checks passed
@mkurz mkurz deleted the play-3-pekko branch December 9, 2023 21:43
@mkurz
Copy link
Member

mkurz commented Dec 9, 2023

@MathisGuillet1 @ndeverge First, just to let you know, I told scala-steward to take into account the groupId change: scala-steward-org/scala-steward#3239

Second, as you have probably seen, I released version 9.0.0 that comes with support for Play 2.9: https://repo1.maven.org/maven2/org/playframework/silhouette/play-silhouette_2.13/9.0.0/

And third, you can do the release for 10.0.0 yourself (whoever is faster or wants to do that, its very easy anyway):

  1. From the current main branch (make sure you pulled the latest commit), create a tag for the release locally on your machine, like in this case 10.0.0:
git tag -s 10.0.0 -m "Releasing version 10.0.0"
  1. Push the tag
  2. Watch the workflow which pushes the artifacts to maven central: https://github.com/playframework/play-silhouette/actions/workflows/publish.yml
  3. After the workflow is green, wait a couple of minutes (somtimes 20, sometimes 50, depends), until artifacts are shown here:
    https://repo1.maven.org/maven2/org/playframework/silhouette/play-silhouette_2.13/10.0.0/
  4. Go to https://github.com/playframework/play-silhouette/releases:
    You will see a release draft, which was created with the release drafter workflow (the one that contains the PR #68). Edit the draft, adjust the version in the title and make sure to choose the tag that was already created, so make sure there is not the sentence "Excellent! This tag will be created from the target when you publish this release.", this is wrong, again, choose the tag you just pushed. And of course, feel free to add any text, sections, information, etc. whatever think makes sense to the release.
    Publish the release, make sure "set as latest version" is checked, done!

So I think you are good now to maintain that library yourself. If you have any questions or run into any problems you can of course ping me anytime.
All the best!

@MathisGuillet1
Copy link
Contributor Author

Awesome, thank you so much @mkurz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants