New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silhouette pekko based with Play 3 #68
Conversation
Pull Request Test Coverage Report for Build 7140787726
💛 - Coveralls |
Thanks, this has to wait a bit. Scala 3 support needs to be done first, then we can make the switch. |
@MathisGuillet1 Can you rebase that for me? Thanks! |
@mkurz I'm on it. I also want to make sure before merging it that we create a protected branch dedicated to play 2.9 and akka to make sure everyone can benefit from the lib wether they stick with play 2.9 or 3.0 |
Yes sure, first the 2.9 thing, doing the 2.9.x dedicated branch and afterwards merging this PR. |
e751afc
to
5220ec4
Compare
@MathisGuillet1 @ndeverge So we are almost there, however I am on a train and need to get out in a couple of minutes for a meeting. On my ride back in the evening (which will take like 2,5 hours) I will finish setting up the release process and switch to our github actions workflows, shouldn't take too long. Thanks for the patience! |
564d65f
to
d4225d5
Compare
@MathisGuillet1 @ndeverge First, just to let you know, I told scala-steward to take into account the groupId change: scala-steward-org/scala-steward#3239 Second, as you have probably seen, I released version 9.0.0 that comes with support for Play 2.9: https://repo1.maven.org/maven2/org/playframework/silhouette/play-silhouette_2.13/9.0.0/ And third, you can do the release for 10.0.0 yourself (whoever is faster or wants to do that, its very easy anyway):
git tag -s 10.0.0 -m "Releasing version 10.0.0"
So I think you are good now to maintain that library yourself. If you have any questions or run into any problems you can of course ping me anytime. |
Awesome, thank you so much @mkurz ! |
A contribution to be able to also release a version based on Play 3 with Pekko