Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of RenderJson #1058

Closed
asolntsev opened this issue Dec 26, 2016 · 1 comment
Closed

Improve performance of RenderJson #1058

asolntsev opened this issue Dec 26, 2016 · 1 comment
Assignees
@asolntsev
Labels
has-pr improvement
Milestone
1.4.4

Comments

@asolntsev
Copy link
Contributor

Instance of class Gson can be reused. This object is thread-safe.

So, instead of creating new Gson() every time, we can create it once and reuse.
@asolntsev asolntsev self-assigned this Dec 26, 2016
asolntsev added a commit to codeborne/play that referenced this issue Dec 26, 2016
@asolntsev
playframework#1058 Improve performance of RenderJson
03e9748 
Instance of class Gson can be reused. This object is thread-safe.
So, instead of creating new Gson() every time, we can create it once and reuse.
@asolntsev asolntsev mentioned this issue Dec 26, 2016
Merged
asolntsev added a commit that referenced this issue Dec 26, 2016
@asolntsev
Merge pull request #1059 from codeborne/improve-render-json-performance
6e432b7 
#1058 Improve performance of RenderJson
@asolntsev
Copy link
Contributor Author

Issue was resolved by PR #1059

@xael-fry xael-fry added this to the 1.4.4 milestone Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
has-pr improvement
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@asolntsev @xael-fry