Avoid restoring of flash and session multiple times per request #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance This is a better fix for stale sessions made in LH issue #1872.
…ion context This ensures that flash and session are resolved only once per request invocation.
asolntsev
force-pushed
the
multiple-session-restore
branch
from
a653565
to
73bb5fd
Compare
|
@xael-fry It seems to be a good PR. Recommended to merge. |
xael-fry
requested changes
Aug 29, 2017
xael-fry
approved these changes
Apr 21, 2020
|
Merged and pushed in master |
|
Looking at changed files this doesn't look like it does anything other than adding an unused import? Maybe you forgot to merge something or something dropped along the line? Or does github maybe just not show it? |
|
Yes, the diff looks strange.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced somewhere in Play 1.3
Session and flash will be restored only once per request (it is at least 3 times currently)
Depends on PR #1180, should be merged after it