Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2140] Make FunctionalTest compatible with Response.writeChunk() #1208

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

davidcostanzo
Copy link
Contributor

This patch updates FunctionalTest to register an onWriteChunk action on the Response objects which it creates so that controller actions which call Response.writeChunk(Object) do not fail with an unhandled exception when invoked from GET().

This patch also includes a regression test, added to FunctionalTestTest, which calls an existing controller action in Application.

@asolntsev
Copy link
Contributor

@xael-fry The PR seems to be ok. Recommended to merge.

@xael-fry xael-fry merged commit 913a5c6 into playframework:master Jan 4, 2018
@xael-fry
Copy link
Member

xael-fry commented Jan 4, 2018

Merged in master thanks
lighthouse #2140

@xael-fry xael-fry added this to the 1.5.1 milestone Jan 4, 2018
@davidcostanzo davidcostanzo deleted the lighthouse-2140-patch branch June 20, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants