Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 13 support #1325

Merged
merged 4 commits into from
Dec 14, 2020
Merged

JDK 13 support #1325

merged 4 commits into from
Dec 14, 2020

Conversation

tomparle
Copy link
Contributor

@tomparle tomparle commented Jan 6, 2020

JDK 13 support (see #1324 for details on files changed).
New features :

  • Play app can be run with JDK 13
  • java.source parameter can be set up to 12 in application config file. Due to a regression with JDT core lib starting from version 3.19.0, we are currently limited to version 3.18.0 that only supports up to JDK 12.
  • lib update : asm 7.2, groovy 2.5.8, javassist 3.26.0-GA, jdt core 3.18.0

Thanks @tazmaniax for his precious contribution !

@tomparle tomparle mentioned this pull request Jan 6, 2020
@xael-fry xael-fry merged commit 1056dbc into playframework:master Dec 14, 2020
@xael-fry
Copy link
Member

@tomparle merge thanks

@tazmaniax
Copy link
Collaborator

tazmaniax commented Dec 14, 2020

@xael-fry I think my pull request #1338 that you merged shortly before supersedes this one so this merge commit should be reverted. The library versions in this pull request are older than the ones in my pull request

@xael-fry xael-fry added this to the 1.6.0 milestone Dec 14, 2020
tomparle added a commit to tomparle/play1 that referenced this pull request Mar 15, 2022
* update to JDK 13 : updated required dependencies and modified reflection access in test that is forbidden since jdk 12

* updated ASM and javassist libs; reverted to jdt code 3.18.0 because of compilation bug with modules from 3.19.0

* updated ASM and javassist libs; reverted to jdt code 3.18.0 because of compilation bug with modules from 3.19.0

Co-authored-by: Alexandre Chatiron <alexandre.chatiron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants