Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions, Travis will be removed #1371

Closed
mkurz opened this issue Jan 22, 2022 · 6 comments
Closed

Switch to GitHub Actions, Travis will be removed #1371

mkurz opened this issue Jan 22, 2022 · 6 comments
Assignees
Milestone

Comments

@mkurz
Copy link
Member

mkurz commented Jan 22, 2022

Hey,

just to let you know, the Play 2 team is migrating all its repositories within the Play Framework organization to GitHub actions in the next weeks.
After that we intend to completely remove the Travis integration from the organization. Therefore I urge you to also move to GitHub actions in the play1 repository as well.
/cc @asolntsev @xael-fry

@tomparle
Copy link
Contributor

Thank you @mkurz ,

with your current migration, would you have any guidelines / tips to help us migrating to GitHub actions ? (I'm not familiar with these)

@mkurz
Copy link
Member Author

mkurz commented Jan 24, 2022

@tomparle
Play1 uses Travis to run tests:

- ant -buildfile ./framework/build.xml test

For GH actions you need to define a workflow, e.g. have a look at https://github.com/playframework/play-json/blob/main/.github/workflows/build-test.yml.
Fortunately the workflow for play1 should be much simpler, there is even official documentation how to run tests with ant: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-ant
Problably you just need to replace the above ant command in that workflow (and probably also on: pull_request)

@xael-fry xael-fry self-assigned this Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
@xael-fry xael-fry added this to the 1.7.0 milestone Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit that referenced this issue Jan 31, 2022
@xael-fry
Copy link
Member

move to GitHub actions done.
;)

@mkurz
Copy link
Member Author

mkurz commented Jan 31, 2022

Great!

@mkurz
Copy link
Member Author

mkurz commented Jan 31, 2022

You still using the travis badge however:
image

xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit to xael-fry/play that referenced this issue Jan 31, 2022
xael-fry added a commit that referenced this issue Jan 31, 2022
@xael-fry
Copy link
Member

You still using the travis badge however: image

Fix it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants