Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2179,#2180]:Fix some bugs. #1238

Closed
wants to merge 2 commits into from

Conversation

moshoujingli
Copy link
Contributor

@moshoujingli moshoujingli commented Jun 4, 2018

Fix that the exclusion check not effects the path which in the exclusion list itself.
Fix sometimes change log config not work.

@asolntsev asolntsev self-requested a review June 4, 2018 13:41
@asolntsev
Copy link
Contributor

@xael-fry PR approved. Recommended to merge.

@moshoujingli
Copy link
Contributor Author

seems another bug in my env.

@moshoujingli moshoujingli changed the title [#2179]:Fix the bug happens while pack a war. [#2179,#2180]:Fix the bug happens while pack a war. Jun 21, 2018
@moshoujingli moshoujingli changed the title [#2179,#2180]:Fix the bug happens while pack a war. [#2179,#2180]:Fix some bugs. Jun 21, 2018
@asolntsev
Copy link
Contributor

@moshoujingli The build is failing. Can you explain why you changed class Logger.java?
In the failing test, your new code Thread.currentThread().getContextClassLoader().getResource(log4jPath) cannot find file log4j.properties.

Tough, the old code Logger.class.getResource(log4jPath) could find it: jar:file:/Users/andrei/projects/play/framework/play-1.5.x-1.5.1-9-gc59fc318.jar!/log4j.properties

@xael-fry
Copy link
Member

Fix it in #1379

@xael-fry xael-fry closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants