[#1252] revert back method to static. Fix calls to deprecated '_' met… #1260
+87
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated '_' method, replaced by __loadClass because '_' is a reserved keyword from jdk9 * [playframework#1252] set java source and target version to use for the build, and remove unused conf file created by mistake * [playframework#1252] ugly fix to make test pass with annotation parameter values with or without quotes, because I do not know how to assert an OR condition in Selenium IDE * [playframework#1252] fix failing tests due to upgrade to JDK9. Upgrade test libraries and remove as much compilation warnings as possible * [playframework#1252] add version 9 * [playframework#1252] update java source detection mechanism to use the version specified in application conf file. Currently supported versions (by jdt compiler) are JDK 1.8 and 10 * [playframework#1252] fix selenium test * [playframework#1252] fix previous loading class method using _ character now reserved in jdk9+ * [playframework#1252] update Play for build with jdk9+. Update libs * update documentation for java.source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hod, replaced by __loadClass because '_' is a reserved keyword from jdk9