Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field.tag as FastTag (Issue #134) #38

Closed

Conversation

mmurray
Copy link
Contributor

@mmurray mmurray commented Nov 15, 2010

http://play.lighthouseapp.com/projects/57987/tickets/134-rewrite-field-tag-as-fasttag

Not sure if you still want this or not, but I saw this ticket sitting in lighthouse and figured I'd take a crack at it.

@guillaumebort
Copy link
Contributor

The tricky part was the:

groovy.util.Eval.me('_caller', _caller, '_caller.' + _arg.replace('.', '?.')

Not sure if your implementation will work for complex fields like:

#{field 'user.address.street'}

?

@mmurray
Copy link
Contributor Author

mmurray commented Nov 18, 2010

You're right, I updated my implementation to handle complex/nested fields.

@guillaumebort
Copy link
Contributor

Ok nice. One more think, the groovy implementation was using either the getter or a direct field access.

user.name

should call user.getName() if exist

@mmurray
Copy link
Contributor Author

mmurray commented Nov 19, 2010

Ok, I think that should do it.

@guillaumebort
Copy link
Contributor

Thank you, merged.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants