Lighthouse 465 patch #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Hoß <mail@shoss.de>
|
Are your sure? would be probably better. |
|
maybe even use os.sep in Python to be OS-independant : dirpath.find('/.') may not work in Windows. |
…t separator, thanks to Jean-Philippe Briend. Signed-off-by: Sebastian Hoß <mail@shoss.de>
|
I've included the change suggested by jpbriend and can confirm that this works as intended on Windows. It now replaces the first call to dirpath.find('/.') > -1 which was already in the code with dirpath.find(os.sep + '.') > -1 |
|
Done. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix inside the modulesrepo.py file which excludes hidden folders from getting picked up by the build-module command.