Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1800] Update compiler for support to java 8 #748

Merged
merged 2 commits into from Apr 16, 2014
Merged

[#1800] Update compiler for support to java 8 #748

merged 2 commits into from Apr 16, 2014

Conversation

xael-fry
Copy link
Member

@cloudbees-pull-request-builder
Copy link

play-1-3-x-pull-requests #185 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

play-1-3-x-pull-requests #186 SUCCESS
This pull request looks good

@Peksa
Copy link

Peksa commented Apr 15, 2014

Can confirm that my small test case works with this pull request!

#743 (comment)

@xael-fry
Copy link
Member Author

Yes I tried it, it was working. but you are right some examples Will be nice I will add some tomorrow.

@xael-fry
[#1800] Update javadoc to link to Java8
8f5e3e5 
[#1800] Add example for java8
@cloudbees-pull-request-builder
Copy link

play-1-3-x-pull-requests #187 SUCCESS
This pull request looks good

xael-fry added a commit that referenced this pull request Apr 16, 2014
@xael-fry
Merge pull request #748 from xael-fry/1800_updateCompilerJava8
3d625c4 
[#1800] Update compiler for support to java 8
@xael-fry xael-fry merged commit 3d625c4 into playframework:1.3.x Apr 16, 2014
@tazmaniax
Copy link
Collaborator

Hi,
I've just tried to run my application using the latest commit of v1.3.x and Java 8 and I'm getting this exception, which is the first of many similar...

chris$ /usr/local/play-1.3.x-16a9b3f/play run  
~        _            _ 
~  _ __ | | __ _ _  _| |
~ | '_ \| |/ _' | || |_|
~ |  __/|_|\____|\__ (_)
~ |_|            |__/   
~
~ play! 1.3.x-16a9b3f, http://www.playframework.org
~
~ Ctrl+C to stop
~ 
objc[15390]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.  
Listening for transport dt_socket at address: 8000  
10:33:50,961 [main] INFO  ~ Starting /Users/chris/git/PTAsocial-MVP  
:: loading settings :: url = jar:file:/usr/local/play-1.3.x-16a9b3f/framework/lib/ivy-2.3.0.jar!/org/apache/ivy/core/settings/ivysettings.xml
10:33:51,196 [main] INFO  ~ Module crud is available (/usr/local/play-1.3.x-16a9b3f/modules/crud)  
10:33:51,196 [main] INFO  ~ Module fastergt is available (/Users/chris/git/PTAsocial-MVP/modules/fastergt-1.8)  
10:33:51,196 [main] INFO  ~ Module db is available (/Users/chris/git/PTAsocial-MVP/local-modules/db-1.1.2)  
10:33:51,197 [main] INFO  ~ Module accesslog is available (/usr/local/play-1.3.x-16a9b3f/modules/accesslog-1.2)  
10:33:51,197 [main] INFO  ~ Module deadbolt is available (/usr/local/play-1.3.x-16a9b3f/modules/deadbolt-1.5.4)  
10:33:51,197 [main] INFO  ~ Module coffee is available (/usr/local/play-1.3.x-16a9b3f/modules/coffee-1.0)  
10:33:51,197 [main] INFO  ~ Module securesocial is available (/Users/chris/git/PTAsocial-MVP/local-modules/securesocial-0.2.7)  
10:33:51,197 [main] INFO  ~ Module morphia is available (/Users/chris/git/PTAsocial-MVP/modules/morphia-1.4.0)  
10:33:52,110 [main] INFO  ~ Loaded image cleaner plugin  
10:33:52,308 [main] WARN  ~ You're running Play! in DEV mode  
10:33:52,376 [main] INFO  ~ Listening for HTTP on port 9000 (Waiting a first request to start) ...  
~ Server is up and running
10:33:59,641 [play-thread-1] ERROR ~ Error in ControllersEnhancer. controllers.Application.updateAccess has not been properly enhanced (fieldAccess javassist.expr.FieldAccess@7de7f493).  
java.lang.RuntimeException: Trying to visit uncompiled class while enhancing. Uncompiled class: models.User  
    at play.classloading.enhancers.Enhancer$ApplicationClassesClasspath.openClassfile(Enhancer.java:75)
    at javassist.ClassPoolTail.openClassfile(ClassPoolTail.java:323)
    at javassist.ClassPool.openClassfile(ClassPool.java:642)
    at javassist.CtClassType.getClassFile2(CtClassType.java:187)
    at javassist.CtClassType.makeFieldCache(CtClassType.java:848)
    at javassist.CtClassType.getMembers(CtClassType.java:839)
    at javassist.CtClassType.getDeclaredField2(CtClassType.java:973)
    at javassist.CtClassType.getField2(CtClassType.java:927)
    at javassist.CtClassType.getField(CtClassType.java:908)
    at javassist.CtClass.getField(CtClass.java:798)
    at javassist.expr.FieldAccess.getField(FieldAccess.java:114)
    at play.classloading.enhancers.ControllersEnhancer$1.edit(ControllersEnhancer.java:49)
    at javassist.expr.ExprEditor.loopBody(ExprEditor.java:198)
    at javassist.expr.ExprEditor.doit(ExprEditor.java:91)
    at javassist.CtBehavior.instrument(CtBehavior.java:712)
    at play.classloading.enhancers.ControllersEnhancer.enhanceThisClass(ControllersEnhancer.java:44)
    at play.CorePlugin.enhance(CorePlugin.java:297)
    at play.plugins.PluginCollection.enhance(PluginCollection.java:561)
    at play.classloading.ApplicationClasses$ApplicationClass.enhance(ApplicationClasses.java:235)
    at play.classloading.ApplicationClassloader.loadApplicationClass(ApplicationClassloader.java:168)
    at play.classloading.ApplicationClassloader.loadClass(ApplicationClassloader.java:85)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
    at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:696)
    at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:564)
    at org.codehaus.groovy.control.ResolveVisitor.resolveToClass(ResolveVisitor.java:709)
    at org.codehaus.groovy.control.ResolveVisitor.resolve(ResolveVisitor.java:275)
    at org.codehaus.groovy.control.ResolveVisitor.resolve(ResolveVisitor.java:243)
    at org.codehaus.groovy.control.ResolveVisitor.transformPropertyExpression(ResolveVisitor.java:881)
    at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:744)
    at org.codehaus.groovy.control.ResolveVisitor.transformMethodCallExpression(ResolveVisitor.java:1086)
    at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:750)
    at org.codehaus.groovy.control.ResolveVisitor.transformBinaryExpression(ResolveVisitor.java:984)
    at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:748)
    at org.codehaus.groovy.ast.expr.MapEntryExpression.transformExpression(MapEntryExpression.java:41)
    at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:759)
    at org.codehaus.groovy.ast.expr.Expression.transformExpressions(Expression.java:63)
    at org.codehaus.groovy.ast.expr.MapExpression.transformExpression(MapExpression.java:61)
    at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:759)
    at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitReturnStatement(ClassCodeExpressionTransformer.java:101)
    at org.codehaus.groovy.ast.stmt.ReturnStatement.visit(ReturnStatement.java:47)
    at org.codehaus.groovy.ast.CodeVisitorSupport.visitBlockStatement(CodeVisitorSupport.java:35)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitBlockStatement(ClassCodeVisitorSupport.java:165)
    at org.codehaus.groovy.control.ResolveVisitor.visitBlockStatement(ResolveVisitor.java:1341)
    at org.codehaus.groovy.ast.stmt.BlockStatement.visit(BlockStatement.java:69)
    at org.codehaus.groovy.ast.CodeVisitorSupport.visitTryCatchFinally(CodeVisitorSupport.java:82)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitTryCatchFinally(ClassCodeVisitorSupport.java:230)
    at org.codehaus.groovy.ast.stmt.TryCatchStatement.visit(TryCatchStatement.java:42)
    at org.codehaus.groovy.ast.CodeVisitorSupport.visitBlockStatement(CodeVisitorSupport.java:35)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitBlockStatement(ClassCodeVisitorSupport.java:165)
    at org.codehaus.groovy.control.ResolveVisitor.visitBlockStatement(ResolveVisitor.java:1341)
    at org.codehaus.groovy.ast.stmt.BlockStatement.visit(BlockStatement.java:69)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClassCodeContainer(ClassCodeVisitorSupport.java:101)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructorOrMethod(ClassCodeVisitorSupport.java:112)
    at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitConstructorOrMethod(ClassCodeExpressionTransformer.java:50)
    at org.codehaus.groovy.control.ResolveVisitor.visitConstructorOrMethod(ResolveVisitor.java:173)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitMethod(ClassCodeVisitorSupport.java:123)
    at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1056)
    at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:50)
    at org.codehaus.groovy.control.ResolveVisitor.visitClass(ResolveVisitor.java:1284)
    at org.codehaus.groovy.control.ResolveVisitor.startResolving(ResolveVisitor.java:148)
    at org.codehaus.groovy.control.CompilationUnit$9.call(CompilationUnit.java:605)
    at org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:843)
    at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:548)
    at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:497)
    at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:480)
    at play.template2.compile.GTGroovyCompileToClass.compileGroovySource(GTGroovyCompileToClass.java:71)
    at play.template2.compile.GTCompiler.compile(GTCompiler.java:82)
    at play.template2.GTTemplateRepo.compileTemplate(GTTemplateRepo.java:296)
    at play.template2.GTTemplateRepo.getTemplateInstance(GTTemplateRepo.java:185)
    at play.template2.GTTemplateRepo.getTemplateInstance(GTTemplateRepo.java:140)
    at play.template2.GTJavaBase.internalRenderTemplate(GTJavaBase.java:133)
    at play.modules.gtengineplugin.gt_integration.GTJavaBase1xImpl.internalRenderTemplate(GTJavaBase1xImpl.java:82)
    at play.template2.GTJavaBase.renderTemplate(GTJavaBase.java:97)
    at play.modules.gtengineplugin.GTTemplate.renderGTTemplate(GTTemplate.java:93)
    at play.modules.gtengineplugin.GTTemplate.internalGTRender(GTTemplate.java:75)
    at play.modules.gtengineplugin.GTTemplate.internalRender(GTTemplate.java:54)
    at play.modules.gtengineplugin.GTTemplate.render(GTTemplate.java:128)
    at play.server.PlayHandler.serve500(PlayHandler.java:792)
    at Invocation.HTTP Request(Play!)

Any idea what might be causing this?
rgds,
Chris

@gslowikowski gslowikowski mentioned this pull request Dec 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xael-fry @cloudbees-pull-request-builder @Peksa @tazmaniax