[#1967] fix broken monitor statistics in status - make the code more future-proof as well #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…future-proof as well
|
Guys, any attention to this? |
|
Sorry I was in holidays in july . I will work on it next week. -------- Original Message --------
|
xael-fry
added a commit
that referenced
this pull request
Aug 10, 2015
[#1967] fix broken monitor statistics in status - make the code more future-proof as well
|
Lighthouse #1967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonitorFactory.getRootMonitor().getBasicData() now returns one additional column (Instance), breaking index-based column access.
This patch now uses proper Monitor.getXX methods instead of error-prone indices and thus restores monitor status functionality in play 1.3.2