fix git clone url #561
fix git clone url #561
Conversation
xuwei-k
commented
Nov 2, 2023
xuwei-k
commented
- same as Update BuildingFromSource.md playframework#12143
- https://github.blog/2021-09-01-improving-git-protocol-security-github/
| @@ -29,9 +29,9 @@ <h1> | |||
| <h1>About the code</h1> | |||
|
|
|||
| <p>Play Framework is hosted on <a href="//github.com/playframework">GitHub</a> using the Git version control system. You can get the code with the following command:</p> | |||
| <pre><code>git clone git://github.com/playframework/playframework.git</code></pre> | |||
| <pre><code>git clone git@@github.com:playframework/playframework.git</code></pre> | |||
There was a problem hiding this comment.
Maybe just https://github.com/playframework/playframework.git? @xuwei-k WDYT?
There was a problem hiding this comment.
Makes sense to use https for new commers that don't have ssh keys set up on their machine to access GitHub. Maybe we can just add both approaches like:
$ git clone https://github.com/playframework/playframework.git
# If you have SSH keys set up associated with your GitHub account you can also use:
$ git clone git@github.com:playframework/playframework.gitbut I am also ok to just use https since no one will push the repo directly...
Anyway, if we change it, needs to be changed here too:
https://www.playframework.com/documentation/3.0.x/BuildingFromSource#Grab-the-source
There was a problem hiding this comment.
Let's get this merged how it is. (Let's assume people know how to clone a GitHub repo and are not total noobs)
There was a problem hiding this comment.
Also better to merge now because currently it's broken...
