Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Scala3 remaining modules #11551

Closed
wants to merge 63 commits into from

Conversation

jtjeferreira
Copy link
Contributor

Pull Request Checklist

Helpful things

Fixes

Fixes #11260

Purpose

Scala 3

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

@jtjeferreira jtjeferreira force-pushed the scala3/PlayServer branch 2 times, most recently from 64d252f to 764e055 Compare November 21, 2022 22:55
@mkurz mkurz added the scala3 label Jan 24, 2023
@jtjeferreira jtjeferreira force-pushed the scala3/PlayServer branch 3 times, most recently from fd9a72d to dfdd6dd Compare January 30, 2023 17:19
@mkurz
Copy link
Member

mkurz commented Jan 30, 2023

@jtjeferreira Same here... Thanks!

@jtjeferreira
Copy link
Contributor Author

@jtjeferreira Same here... Thanks!

Fixed, but this is still WIP because there are some tests failing.
I think the failures are related to using NettyBackend instead of AkkaHttp. Feel free to have a look

@mkurz
Copy link
Member

mkurz commented Feb 14, 2023

@jtjeferreira Can you please resolve the conflicts once more, obrigado!

@jtjeferreira
Copy link
Contributor Author

@jtjeferreira Can you please resolve the conflicts once more, obrigado!

Will do after #11550 is merged

@mkurz
Copy link
Member

mkurz commented Feb 17, 2023

@jtjeferreira I wanted to take quick a look at this, so I rebased myself and resolved the conflicts.

@mkurz
Copy link
Member

mkurz commented Feb 28, 2023

Wow. It's green 😉 Not perfect yet however, but very very nice... I will provide more details what I have done here the next days, too late here now...

@jtjeferreira
Copy link
Contributor Author

Wow. It's green 😉 Not perfect yet however, but very very nice... I will provide more details what I have done here the next days, too late here now...

Thanks for pushing this to the finish line.

Regarding b2f7a71 (#11551) and the java.lang.VerifyError: Bad type on operand stack error, will you open an issue in dotty? That looks really scary...

@mkurz
Copy link
Member

mkurz commented Feb 28, 2023

Thanks for pushing this to the finish line.

It's not completely done, there are some things I am not yet happy with. I will give this PR a pause for a couple of days since I have other stuff to do as well. But IMHO it's a huge step forward, there is nothing really blocking and everything that needs to be done is pretty clear.

Regarding b2f7a71 (#11551) and the java.lang.VerifyError: Bad type on operand stack error, will you open an issue in dotty? That looks really scary...

Yeah I was thinking about that, I just was too tired yesterday, also have to come up with an isolated reproducer.

@mkurz
Copy link
Member

mkurz commented Feb 28, 2023

We also want to have a Scala 3 migration page in the docs for migration steps we already know about.

@mkurz
Copy link
Member

mkurz commented Feb 28, 2023

Thanks for pushing this to the finish line.

Oh and @jtjeferreira: Thank you!

@mkurz mkurz mentioned this pull request Mar 1, 2023
@mkurz
Copy link
Member

mkurz commented Mar 7, 2023

Started to split this PR into multiple ones, starting with #11698

@mkurz
Copy link
Member

mkurz commented Apr 4, 2023

@jtjeferreira like for #11550, thanks! This has been incorporated into the main branch via various pull requests: https://github.com/playframework/playframework/issues?q=label%3Ascala3+is%3Aclosed

Yesterday I tagged Play 2.9.0-M3 which now publishes Scala 3 artifacts. Everyone is welcome to try it and give feedback. You can also get started with a seed project by using sbt new playframework/play-scala-seed.g8 --branch 2.9.x

@mkurz mkurz closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 3
2 participants