New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Scala3 remaining modules #11551
Conversation
64d252f
to
764e055
Compare
fd9a72d
to
dfdd6dd
Compare
@jtjeferreira Same here... Thanks! |
dfdd6dd
to
b914cb7
Compare
Fixed, but this is still WIP because there are some tests failing. |
@jtjeferreira Can you please resolve the conflicts once more, obrigado! |
Will do after #11550 is merged |
b914cb7
to
3823d70
Compare
@jtjeferreira I wanted to take quick a look at this, so I rebased myself and resolved the conflicts. |
3823d70
to
0c8c973
Compare
8cd782c
to
d0e538f
Compare
Wow. It's green 😉 Not perfect yet however, but very very nice... I will provide more details what I have done here the next days, too late here now... |
4dc11a0
to
d443df7
Compare
Thanks for pushing this to the finish line. Regarding |
It's not completely done, there are some things I am not yet happy with. I will give this PR a pause for a couple of days since I have other stuff to do as well. But IMHO it's a huge step forward, there is nothing really blocking and everything that needs to be done is pretty clear.
Yeah I was thinking about that, I just was too tired yesterday, also have to come up with an isolated reproducer. |
We also want to have a Scala 3 migration page in the docs for migration steps we already know about. |
Oh and @jtjeferreira: Thank you! |
Scala 2.13 already warned about that: warning: Unicode escapes in triple quoted strings are deprecated, use the literal character instead
Started to split this PR into multiple ones, starting with #11698 |
@jtjeferreira like for #11550, thanks! This has been incorporated into the main branch via various pull requests: https://github.com/playframework/playframework/issues?q=label%3Ascala3+is%3Aclosed Yesterday I tagged Play 2.9.0-M3 which now publishes Scala 3 artifacts. Everyone is welcome to try it and give feedback. You can also get started with a seed project by using |
Pull Request Checklist
Helpful things
Fixes
Fixes #11260
Purpose
Scala 3
Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?