Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-heroku plugin no longer maintained #12327

Closed
sief opened this issue Jan 13, 2024 · 3 comments
Closed

sbt-heroku plugin no longer maintained #12327

sief opened this issue Jan 13, 2024 · 3 comments

Comments

@sief
Copy link
Contributor

sief commented Jan 13, 2024

The sbt-heroku plugin as described here https://www.playframework.com/documentation/3.0.x/ProductionHeroku#Deploying-with-the-sbt-heroku-plugin is no longer maintained: https://github.com/heroku/heroku-sbt-plugin

To deploy directly to Heroku without pushing to a Git repository, you need to use the heroku-jvm-application-deployer https://github.com/heroku/heroku-jvm-application-deployer which requires a fat Jar.

The Play documentation describes creating a fat jar using the sbt-assembly plugin as not officially supported: https://www.playframework.com/documentation/3.0.x/Deploying#Using-the-sbt-assembly-plugin

What is the reason that it's not officially supported?

@mkurz
Copy link
Member

mkurz commented Jan 15, 2024

What is the reason that it's not officially supported?

It's been a while since this docs were added in

I guess the meaning was that the sbt-assembly plugin (https://github.com/sbt/sbt-assembly) was not / is not maintained by the Playframework maintainers. So if you use it and run into problems you are on your own or have to contact the author of the plugin. However, meanwhile, I am pretty sure the plugin should be safe to use, it's quite popular.

@ndeverge So you forked the heroku-sbt-plugin, any reason you can not migrate to the Heroku JVM Application Deployer?

@ndeverge
Copy link
Member

I tried to create a fat jar to use with the heroku-jvm-application-deployer, but it did not work (I did not have the time to investigate further at the moment), and it was easier for me to fork the sbt-heroku plugin.

@sief
Copy link
Contributor Author

sief commented Jan 16, 2024

Same here. The sbt-native-packager (stage or dist) works out of the box, as does the sbt-heroku plugin when used with sbt stage. I had never used the sbt-assembly plugin before and when I tried it with my multi project sbt build, I got a ton of deduplicate errors. Is there a way to build a fat Jar without adjusting these merge strategies, similar to what the sbt-native-packager does?

@playframework playframework locked and limited conversation to collaborators Jan 22, 2024
@mkurz mkurz converted this issue into discussion #12334 Jan 22, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants