TestServer.isRunning throws an exception when the server is not running.

[tanin47]

Play Version

Latest

API

Scala

Operating System

N/A

JDK

N/A

Library Dependencies

Expected Behavior

I'd expect it to return true or false

Actual Behavior

It raises an exception when the server is not running.

Reproducible Test Case

playframework/testkit/play-test/src/main/scala/play/api/test/TestServer.scala

Line 28 in a77da07

throw new IllegalStateException("Test server not running")

Here's the code:

case class TestServer(config: ServerConfig, application: Application, serverProvider: Option[ServerProvider]) {
  ...

  private def getTestServerIfRunning: Server = {
    val s = server
    if (s == null) {
      throw new IllegalStateException("Test server not running")
    }
    s
  }
  ...

  def runningHttpPort: Option[Int] = getTestServerIfRunning.httpPort

  @ApiMayChange
  def isRunning: Boolean = runningHttpPort.nonEmpty || runningHttpsPort.nonEmpty
}

I wonder if we should catch an exception in isRunning.

[mkurz]

Best is probably if getTestServerIfRunning would return an Option[Server] instead of thrown an exception...
Ahh.. I see it's private so we could change that right now.
What do you think? you want to provide pull request?

[tanin47]

Sounds good. I can do that this weekend. Would love to help contribute.

[tanin47]

When I said "this weekend", I mean "a weekend" 🤣 . Here's the PR: #12352