WAMP Subprotocol rejected by Netty

[blopker]

I'm trying to implement a WAMP module for Play so I can do pub/sub and RPC over websockets. The canonical WAMP JavaScript library is AutobahnJS which sends the Sec-WebSocket-Protocol header set to 'wamp'. This subprotocol is rejected by the WebSocketServerHandshaker13.java in Netty. The reason is that in Play's WebSocketHandshake.scala the handshaker is constructed with null for the subprotocol argument.

I looked at the Netty source and according to the comments the null value means subprotocols are not supported. This seems overly constrained to me for Play. I'm going to ask the Netty people for a 'wildcard' value to accept all subprotocols, but for now can we change null to "wamp"? This won't affect websocket requests with no protocol header, but it will allow WAMP to function normally.

Thanks!

[vkoop]

Would be really nice, if it would work! Would love to use Autobahn with Playframework!

[jroper]

I think we should wait for wildcard support in Netty.

[bowenliang123]

How to fix this problem? Or how to deploy WAMP with Play?

[blopker]

The work around for the WAMPlay library is here: https://github.com/blopker/WAMPlay/issues/1

[blopker]

Also, Netty now allows a comma separated list of allowed sub-protocols. Adding wamp to the websocket handler constructor will not preclude adding other protocols. It would be great if this could be added now.

[blopker]

Check out #1101 for the fix!

[blopker]

Update with Netty: netty/netty#1374
They'll have a wildcard sub-protocol in their next release.

[benmccann]

I think this issue can be closed now

[bowenliang123]

Wow, cool~ time to close this issue.

[blopker]

Yep! I forgot about this one.